-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add impersonation support to send_packet service #201
Add impersonation support to send_packet service #201
Conversation
@zxdavb Any reasons for not merging this PR? |
@zxdavb Hello? I'd appreciate some feedback here... |
Rebase it and I will merge it. |
7aa619c
to
08f1e82
Compare
@zxdavb Done. |
Hi, did you run |
Please:
Your commit should pass the latter two tests. The main one is |
Alright, I will check this out. |
@zxdavb Done.
|
@Kars-de-Jong Can you rebase against the latest master - also run:
|
@zxdavb After running Some tests fail, but not in any code I touched. They also fail on the master branch (this output is from master):
|
ee366c4
to
07b143b
Compare
This is definitely not your fault.
The above is due to an issue with the quiesce... I have added this, for future: https://github.com/zxdavb/ramses_cc/wiki/How-to-submit-a-PR |
This change adds support for impersonation using the send_packet service.
I use it to send fan_demand packets from my faked CO2 sensor, because ramses_rf doesn't support that yet.
I couldn't practically solve this use-case with a remote, because you have to predefine the commands in a remote, which is not very suitable for fan_demand packets, since you specify the demand percentage - you would need to create 100 commands for it.
I submitted this PR before, I hope you would consider merging it. If not, I will have to switch to using my own fork instead.