-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete directory after delete all images #68
Closed
bscheshirwork
wants to merge
6
commits into
zxbodya:master
from
bscheshirwork:delete-directory-after-delete-all-images
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8473f4a
Refactor removeDirrectory; Check errors of operations
bscheshirwork 506aee3
Catch exception for non-existing file or similar case
bscheshirwork 72242e6
Remove directory after remove all images
bscheshirwork c9fceda
add line to changelog.md
bscheshirwork bb013e8
Fix typo
bscheshirwork 760d058
refactor beforeDelete
bscheshirwork File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -142,8 +142,7 @@ public function beforeDelete() | |
foreach ($images as $image) { | ||
$this->deleteImage($image->id); | ||
} | ||
$dirPath = $this->directory . '/' . $this->getGalleryId(); | ||
@rmdir($dirPath); | ||
$this->removeDirectory($this->getDirectoryPath()); | ||
} | ||
|
||
public function afterFind() | ||
|
@@ -223,6 +222,27 @@ public function getFilePath($imageId, $version = 'original') | |
return $this->directory . '/' . $this->getFileName($imageId, $version); | ||
} | ||
|
||
public function getDirectoryPath() | ||
{ | ||
return $this->directory . '/' . $this->getGalleryId(); | ||
} | ||
|
||
/** | ||
* Get Gallery Id | ||
* | ||
* @return mixed as string or integer | ||
* @throws Exception | ||
*/ | ||
public function getGalleryId() | ||
{ | ||
$pk = $this->owner->getPrimaryKey(); | ||
if (is_array($pk)) { | ||
return implode($this->pkGlue, $pk); | ||
} else { | ||
return $pk; | ||
} | ||
} | ||
|
||
/** | ||
* Replace existing image by specified file | ||
* | ||
|
@@ -252,31 +272,48 @@ public function replaceImage($imageId, $path) | |
} | ||
} | ||
|
||
/** | ||
* Remove single image file | ||
* @param $fileName | ||
* @return bool | ||
*/ | ||
private function removeFile($fileName) | ||
{ | ||
return FileHelper::unlink($fileName); | ||
try { | ||
return FileHelper::unlink($fileName); | ||
} catch (\yii\base\ErrorException $exception) { | ||
return false; | ||
} | ||
} | ||
|
||
/** | ||
* Get Gallery Id | ||
* | ||
* @return mixed as string or integer | ||
* @throws Exception | ||
* Remove a folders for gallery files | ||
* @param $filePath string the filename of image | ||
* @return bool | ||
*/ | ||
public function getGalleryId() | ||
private function removeDirectory($filePath) | ||
{ | ||
$pk = $this->owner->getPrimaryKey(); | ||
if (is_array($pk)) { | ||
return implode($this->pkGlue, $pk); | ||
} else { | ||
return $pk; | ||
try { | ||
FileHelper::removeDirectory(dirname($filePath)); | ||
} catch (\yii\base\ErrorException $exception) { | ||
return false; | ||
} | ||
} | ||
|
||
return true; | ||
} | ||
|
||
/** | ||
* Create a folders for gallery files | ||
* @param $filePath string the filename of image | ||
* @return bool | ||
*/ | ||
private function createFolders($filePath) | ||
{ | ||
return FileHelper::createDirectory(FileHelper::normalizePath(dirname($filePath)), 0777); | ||
try { | ||
return FileHelper::createDirectory(FileHelper::normalizePath(dirname($filePath)), 0777); | ||
} catch (\yii\base\Exception $exception) { | ||
return false; | ||
} | ||
} | ||
|
||
/////////////////////////////// ========== Public Actions ============ /////////////////////////// | ||
|
@@ -287,10 +324,7 @@ public function deleteImage($imageId) | |
$this->removeFile($filePath); | ||
} | ||
$filePath = $this->getFilePath($imageId, 'original'); | ||
$parts = explode('/', $filePath); | ||
$parts = array_slice($parts, 0, count($parts) - 1); | ||
$dirPath = implode('/', $parts); | ||
@rmdir($dirPath); | ||
$this->removeDirectory($filePath); | ||
|
||
$db = \Yii::$app->db; | ||
$db->createCommand() | ||
|
@@ -314,6 +348,9 @@ function ($image) use (&$removed) { | |
} | ||
); | ||
} | ||
if (is_null($this->_images)) { | ||
$this->removeDirectory($this->getDirectoryPath()); | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is not correct - |
||
} | ||
|
||
public function addImage($fileName) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be private?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO This functional can be use outside widget for build the path to galery folder of model
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also we can redefine it in children