Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete directory after delete all images #68

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 56 additions & 19 deletions GalleryBehavior.php
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,7 @@ public function beforeDelete()
foreach ($images as $image) {
$this->deleteImage($image->id);
}
$dirPath = $this->directory . '/' . $this->getGalleryId();
@rmdir($dirPath);
$this->removeDirectory($this->getDirectoryPath());
}

public function afterFind()
Expand Down Expand Up @@ -223,6 +222,27 @@ public function getFilePath($imageId, $version = 'original')
return $this->directory . '/' . $this->getFileName($imageId, $version);
}

public function getDirectoryPath()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be private?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO This functional can be use outside widget for build the path to galery folder of model

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also we can redefine it in children

{
return $this->directory . '/' . $this->getGalleryId();
}

/**
* Get Gallery Id
*
* @return mixed as string or integer
* @throws Exception
*/
public function getGalleryId()
{
$pk = $this->owner->getPrimaryKey();
if (is_array($pk)) {
return implode($this->pkGlue, $pk);
} else {
return $pk;
}
}

/**
* Replace existing image by specified file
*
Expand Down Expand Up @@ -252,31 +272,48 @@ public function replaceImage($imageId, $path)
}
}

/**
* Remove single image file
* @param $fileName
* @return bool
*/
private function removeFile($fileName)
{
return FileHelper::unlink($fileName);
try {
return FileHelper::unlink($fileName);
} catch (\yii\base\ErrorException $exception) {
return false;
}
}

/**
* Get Gallery Id
*
* @return mixed as string or integer
* @throws Exception
* Remove a folders for gallery files
* @param $filePath string the filename of image
* @return bool
*/
public function getGalleryId()
private function removeDirectory($filePath)
{
$pk = $this->owner->getPrimaryKey();
if (is_array($pk)) {
return implode($this->pkGlue, $pk);
} else {
return $pk;
try {
FileHelper::removeDirectory(dirname($filePath));
} catch (\yii\base\ErrorException $exception) {
return false;
}
}

return true;
}

/**
* Create a folders for gallery files
* @param $filePath string the filename of image
* @return bool
*/
private function createFolders($filePath)
{
return FileHelper::createDirectory(FileHelper::normalizePath(dirname($filePath)), 0777);
try {
return FileHelper::createDirectory(FileHelper::normalizePath(dirname($filePath)), 0777);
} catch (\yii\base\Exception $exception) {
return false;
}
}

/////////////////////////////// ========== Public Actions ============ ///////////////////////////
Expand All @@ -287,10 +324,7 @@ public function deleteImage($imageId)
$this->removeFile($filePath);
}
$filePath = $this->getFilePath($imageId, 'original');
$parts = explode('/', $filePath);
$parts = array_slice($parts, 0, count($parts) - 1);
$dirPath = implode('/', $parts);
@rmdir($dirPath);
$this->removeDirectory($filePath);

$db = \Yii::$app->db;
$db->createCommand()
Expand All @@ -314,6 +348,9 @@ function ($image) use (&$removed) {
}
);
}
if (is_null($this->_images)) {
$this->removeDirectory($this->getDirectoryPath());
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not correct - is_null($this->_images) means only that getImages() method was not called yet

}

public function addImage($fileName)
Expand Down
5 changes: 4 additions & 1 deletion changelog.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Gallery manaager extension changelog
# Gallery manager extension changelog

Nov 19, 2018
- After remove all gallery images from model the corresponded folder also will be removing

Apr 3, 2015
- Added possibility to change table name for gallery images

Expand Down