fix: allow State as a valid HA option for 6 States with No Data State Parameter options #6606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not being a HA user and a beginner in ZWave JS, this is highly likely not correct, but I can handle that. This is a potential hack to address #6584. For the 6 states that allow the "No Data" option as state parameters, the device mfr might not provide a state parameter (optional per the ZW spec) and in this case ZWave JS sends the state, not the state parameter. This throws an HA validation error. The intent of this PR is to add the "state" to the "state parameter" list so that validation will succeed. Conveniently all the "states" are higher than any Zwave "state parameter" options, so the device will never send that "state parameter". It is only to inform HA that the value is allowed and means no data was provided. Signed-off-by: Bob Eckhoff <[email protected]>
|
I'm afraid the approach wasn't correct. When there are possible states, we want the value to be one of those, not introduce duplicate states. #6719 solves the issue that way. |
|
no worries. Just thought I would try for the learning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description here
Not being a HA user and a beginner in ZWave JS, this is highly likely not correct, but I can handle that.
This is a potential hack to address #6584. For the 6 states that allow the "No Data" option as state parameters, the device mfr might not provide a state parameter (optional per the ZW spec) and in this case ZWave JS sends the state, not the state parameter. This throws an HA validation error. The intent of this PR is to add the "state" to the "state parameter" list so that validation will succeed. Conveniently all the "states" are higher than any Zwave "state parameter" options, so the device will never send that "state parameter". It is only to inform HA that the value is allowed and means no data was provided.