feat(config): add a new productId and add parameters to 14297/ZW1002 outlet #6517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Label is the same but I got one with a newer product Id. Also added the parameters/metadata from the other zw1002 entry as the configuration parameters are the same. (as written on the manual in the box)
allenbenz
changed the title
|
@AlCalzone anything that needs to change to make this PR acceptable? |
AlCalzone
reviewed
Apr 2, 2024
Comment on lines
7
to
14
| { | ||
| "productType": "0x4952", | ||
| "productId": "0x3233" | ||
| }, | ||
| { | ||
| "productType": "0x4952", | ||
| "productId": "0x3236" | ||
| } |
There was a problem hiding this comment.
@jascoproducts can you confirm if these two are actually the same product from a Z-Wave perspective? Do both have the LED indicator config param?
There was a problem hiding this comment.
@jascoproducts can you confirm if these two are actually the same product from a Z-Wave perspective? Do both have the LED indicator config param?
These are essentially the same products and have identical functionality. Both are the 14297 In-Wall Outlet, TR, Lt Almd but 0x3236 has S2 and Smart Start while 0x3233 does not.
They both have the LED configuration parameter:
There was a problem hiding this comment.
Thanks, then we can treat them as identical
AlCalzone
approved these changes
Apr 4, 2024
AlCalzone
added a commit
that referenced
this pull request
Apr 4, 2024
### Bugfixes * Add workaround for devices that omit notification event parameters instead of sending "no data" (#6719) ### Config file changes * Added 11 Shelly Qubino Wave devices (#6633) * Add Heatit Leakage Water Stopper (#6605) * Add Ring Smoke/CO Listener (#6591) * Add ZVIDAR Z-TRV-V01 thermostatic valve (#6542) * Add Safe Grow NSG-AB-02 Z-Wave Plus Smart Outlet Plug (#6535) * Add a new productId and add parameters to 14297/ZW1002 outlet (#6517)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Label is the same but I got one with a newer product Id.
Also added the parameters/metadata from the other zw1002 entry as the configuration parameters are the same. (as written on the manual in the box)