fix: look at all test files to resolve dirty tests (#7045)

.eslintrc.js

@@ -18,7 +18,7 @@ module.exports = {
 	parserOptions: {
 		ecmaVersion: 2023, // Allows for the parsing of modern ECMAScript features
 		sourceType: "module", // Allows for the use of imports
-		project: "./tsconfig.eslint.json",
+		project: "./tsconfig.all.json",
 		tsconfigRootDir: __dirname,
 	},
 	extends: [

packages/core/src/values/Primitive.ts

@@ -1,5 +1,5 @@
 import {
-	MAX_NODES,
+	MAX_NODES_LR,
 	NUM_LR_NODES_PER_SEGMENT,
 	NUM_NODEMASK_BYTES,
 } from "../consts";
@@ -287,7 +287,7 @@ export function parseLongRangeNodeBitMask(
 }
 
 export function encodeNodeBitMask(nodeIDs: readonly number[]): Buffer {
-	return encodeBitMask(nodeIDs, MAX_NODES);
+	return encodeBitMask(nodeIDs, MAX_NODES_LR);
 }
 
 export function encodeLongRangeNodeBitMask(

packages/maintenance/src/codefind.ts

@@ -177,7 +177,7 @@ function getCodePathAtPosition(
 }
 
 export function codefind(query: CodeFindQuery): Result[] {
-	const tsConfig = loadTSConfig("zwave-js", false);
+	const tsConfig = loadTSConfig(undefined, "all");
 	const program = ts.createProgram(tsConfig.fileNames, {
 		...tsConfig.options,
 		preserveSymlinks: false,

packages/maintenance/src/resolveDirtyTests.ts

@@ -206,7 +206,7 @@ export async function resolveDirtyTests(
 	// Create a Program to represent the project, then pull out the
 	// source file to parse its AST.
 
-	const tsConfig = loadTSConfig(undefined, false);
+	const tsConfig = loadTSConfig(undefined, "all");
 	const program = ts.createProgram(tsConfig.fileNames, {
 		...tsConfig.options,
 		preserveSymlinks: false,

packages/maintenance/src/tsAPITools.ts

@@ -16,7 +16,7 @@ export const tsConfigFilePathForDocs = path.join(
 
 export function loadTSConfig(
 	packageName: string = "",
-	build: boolean = true,
+	variant: string = "build",
 ): {
 	options: ts.CompilerOptions;
 	fileNames: string[];
@@ -25,7 +25,7 @@ export function loadTSConfig(
 		packageName ? path.join(repoRoot, `packages/${packageName}`) : repoRoot,
 		// eslint-disable-next-line @typescript-eslint/unbound-method
 		ts.sys.fileExists,
-		build ? "tsconfig.build.json" : "tsconfig.json",
+		variant ? `tsconfig.${variant}.json` : "tsconfig.json",
 	);
 	if (!configFileName) throw new Error("tsconfig.json not found");
 
@@ -39,6 +39,8 @@ export function loadTSConfig(
 	);
 	if (!parsedCommandLine) throw new Error("could not parse tsconfig.json");
 
+	// FIXME: If parsedCommandLine contains project references, but no fileNames, we need to resolve the references
+
 	return {
 		options: parsedCommandLine.options,
 		fileNames: parsedCommandLine.fileNames,

tsconfig.all.json

@@ -0,0 +1,7 @@
+// Custom tsconfig that includes all `.ts` files in the repo
+// This is used for linting and other maintenance tasks
+{
+	"extends": "./tsconfig.base.json",
+	"include": ["**/*.ts"],
+	"exclude": ["**/build/**", "**/node_modules/**"]
+}

turbo.json

@@ -53,7 +53,7 @@
 				// The style based linting tasks depend on the corresponding configuration in the repo root
 				"../../.eslintrc.js",
 				"../../.eslintignore",
-				"../../tsconfig.eslint.json"
+				"../../tsconfig.all.json"
 			]
 		},
 		"lint:ts:fix": {
@@ -65,7 +65,7 @@
 				// The style based linting tasks depend on the corresponding configuration in the repo root
 				"../../.eslintrc.js",
 				"../../.eslintignore",
-				"../../tsconfig.eslint.json"
+				"../../tsconfig.all.json"
 			],
 			"outputs": ["**/*.{ts,json}"]
 		},