Skip to content

Commit

Permalink
Update TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
mr-ubik committed Feb 7, 2020
1 parent ed7f3cd commit 7efd7dd
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
1 change: 0 additions & 1 deletion src/ashpy/contexts/context.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ def __init__(
"""
self._distribute_strategy = tf.distribute.get_strategy()

# TODO: are metrics really needed right now?
self._metrics = metrics if metrics else ()
self._dataset = dataset
self._log_eval_mode = log_eval_mode
Expand Down
1 change: 1 addition & 0 deletions src/ashpy/restorers/restorer.py
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ def _check_model_construction(restored_model: tf.keras.Model) -> bool:
as layers.weights.
TODO: add docs for the exception.
TODO: add test case for the Sequential without input shape
"""
try:
if restored_model.weights == []:
Expand Down
7 changes: 6 additions & 1 deletion tests/callbacks/__init__.py
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@
"""Test for callbacks."""
"""
Test for callbacks.
TODO: test a callback that retrieves a Metric from its Context
TODO: Restructure these tests
"""

0 comments on commit 7efd7dd

Please sign in to comment.