Fixed issue, when user has no role, but has permissions and object_ch…

…ecker returned false
zurek11 · Oct 15, 2020 · 9844667 · 9844667
1 parent 293214d
commit 9844667
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,3 +5,7 @@
 ## 0.1.1 : 2020-10-05
 
 - 🌧 Changed Django version requirement from 3.0.* to >= 2.0
+
+## 0.1.2 : 2020-10-05
+
+- 😺 Fixed issue, when user has no role, but has permissions and object_checker returned false.
diff --git a/object_checker/base_object_checker.py b/object_checker/base_object_checker.py
@@ -46,9 +46,6 @@ def has_object_permission(checker_name: str, user: User, obj) -> bool:
         checker = ObjectChecker.retrieve_checker(checker_name)
         user_roles = ObjectChecker.get_user_roles(user)
 
-        if user_roles:
-            has_permission = any([checker(user_role, user, obj) for user_role in user_roles])
-        else:
-            has_permission = False
+        has_permission = any([checker(user_role, user, obj) for user_role in user_roles])
 
     return has_permission
diff --git a/object_checker/version.py b/object_checker/version.py
@@ -1 +1 @@
-__version__ = '0.1.1'
+__version__ = '0.1.2'