action_sheet: Offer "Mark channel as read" in channel action sheet #1317
+313
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chimnayajith
force-pushed
the
1226-mark-stream-as-read
branch
3 times, most recently
from
0a8811a to
8a4937e
Compare
|
@chrisbobbe I’ve addressed all the requested changes. Please take a look. Thank you! |
chrisbobbe
reviewed
Feb 5, 2025
Comment on lines
+336
to
+340
| @override | ||
| Future<void> onLongPress() async { | ||
| // TODO(#1272) action sheet for DM conversation | ||
| return; | ||
| } |
There was a problem hiding this comment.
bump on #1317 (comment) ; let me know if it doesn't make sense.
chrisbobbe
reviewed
Feb 6, 2025
chimnayajith
force-pushed
the
1226-mark-stream-as-read
branch
4 times, most recently
from
06ed689 to
93d3199
Compare
chimnayajith
force-pushed
the
1226-mark-stream-as-read
branch
2 times, most recently
from
26973af to
5768d19
Compare
added 3 commits
February 8, 2025 00:29
…ct class Move the high level operation markNarrowAsRead into the new ZulipAction abstract class, per discussion in: https://chat.zulip.org/#narrow/channel/516-mobile-dev-help/topic/.23F1317.20showErrorDialog/near/2080576 This makes it clearer at call sites that the methods combine API operations with UI feedback.
Figma doesn't specify this icon explicitly. Based on discussions in PR zulip#1274 (zulip#1274 (comment)), we chose this icon for consistency with the "Mark as read" option on web. reference: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=3512-7&t=iwirdCVutQls9R0A-4
chimnayajith
force-pushed
the
1226-mark-stream-as-read
branch
from
5768d19 to
da7af54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Adds a channel action sheet with a "Mark channel as read" option, accessible via long-press from both the inbox and subscription list pages. The action sheet is triggered by long-pressing on a channel header.
Related Issues
Screenshots
Additional Information
Currently the action sheet only appears in subscription list when the channel has unread messages, since the sheet doesn't have any default buttons.