Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support general chat #1297

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Support general chat #1297

wants to merge 12 commits into from

Conversation

PIG208
Copy link
Member

@PIG208 PIG208 commented Jan 22, 2025 •
edited
Loading

@PIG208 PIG208 force-pushed the pr-general-chat branch 11 times, most recently from da55117 to b38c9bc Compare January 29, 2025 23:59
PIG208 added 12 commits January 30, 2025 18:47
@PIG208
autocomplete test [nfc]: Use plain strings for finding topic
1f37b54 
instead of inferring it from a TopicName

Signed-off-by: Zixuan James Li <[email protected]>
@PIG208
autocomplete test [nfc]: Remove checkTopicShown helper
39a529d 
Signed-off-by: Zixuan James Li <[email protected]>
@PIG208
compose [nfc]: Derive hintText from topic display name
35e6044 
Signed-off-by: Zixuan James Li <[email protected]>
@PIG208
compose test: Add tests for hintText
c520e3a 
Signed-off-by: Zixuan James Li <[email protected]>
@PIG208
store: Add realmEmptyTopicDisplayName
7c659cb 
Signed-off-by: Zixuan James Li <[email protected]>
@PIG208
autocomplete: Handle general chat for topics
8553903 
Signed-off-by: Zixuan James Li <[email protected]>
@PIG208
inbox: Display realmEmptyTopicDisplayName on empty topic
14597e7 
Signed-off-by: Zixuan James Li <[email protected]>
@PIG208
msglist: Display realmEmptyTopicDisplayName on empty topic
290a1a0 
Signed-off-by: Zixuan James Li <[email protected]>
@PIG208
compose: Show special hint text for inputs if empty topic
43049ee 
Signed-off-by: Zixuan James Li <[email protected]>
@PIG208
compose: Send to general chat if empty topic
89b66a6 
Signed-off-by: Zixuan James Li <[email protected]>
@PIG208
api: Make displayName nullable
daf6f90 
Signed-off-by: Zixuan James Li <[email protected]>
@PIG208
api: Indicate support for handling empty topics
4bdbc85 
Signed-off-by: Zixuan James Li <[email protected]>
@PIG208 PIG208 marked this pull request as ready for review January 30, 2025 23:48
@PIG208
Copy link
Member Author

PIG208 commented Jan 30, 2025 •
edited
Loading

I expect #1301 to be merged pretty soon (which may need some handling for general chat as it cannot be resolved), but the rest of the PR should be ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@PIG208