Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scamp #14

Open
wants to merge 48 commits into
base: master
Choose a base branch
from
Open

Scamp #14

wants to merge 48 commits into from

Conversation

Conor-Larison
Copy link

Add 'ERRX2WIN_IMAGE' and 'ERRY2WIN_IMAGE' keywords to sextractor.param

@dannygoldstein
add dependency on scamp
f65a1f3 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
add astrometric calibration
49b4801 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
implement astrometric solution in make_coadd, move run_coadd body to
4f5ff38 
_coadd_from_images

Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
typo
8587926 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
exc -->str
63c8045 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
handle mapped/non-mapped
b3804ff 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
allow initializing catalogs from CalibratableImageBase
104eeff 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
remove depcheck
c30cb39 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
str
036593b 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
preserve other HDUs in writing of catalogs
95efb43 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
try a new method to propagate other HDUs/
c65db29 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
use swarp ZP key
2be6385 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
write extname in ldac format
53964e0 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
add default.scamp
f8de641 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
also apply astrometric solution to masks
ca033d9 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
write extname in LDAC format
eecda4c 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
dont solve for photometric calibration in scamp
47c1164 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
copy headers correctly out of transaction
72c2f2f 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
remove photo keys from scamp .head files
a1a6918 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
try forcing coercion to ascii
3b41c30 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
forgot sep
b5b2fee 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
make set_date true by default
8f4ce9d 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
remove french characters from header
f13d910 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
do it manually
7474cf0 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
make catalog check safe
ea577a7 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
try using TPV
f120b60 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
resolve scamp after making coadd
bce23eb 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
solve astrometry before calculating seeing
4e50236 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
calculate catalog in solve astrometry if needed
9fb4c84 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
move second cat check after first
ed4b9ed 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
remove french characters from fitsheader
ff5ca79 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
lines already have \n
51f0075 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
split on ' ' not '='
7808bd3 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
actually just take first 8 chars
416b326 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
load fits header from string
4f2e833 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
remove history
d3aec6b 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
use TAN, make sure scamp uses MJD-OBS in Ztf images
28e41d9 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
save transact image
c5e5735 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
dont accept masks in calibrate_astrometry
5ac7083 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
remake catalog after calibration
306028a 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
use TPV and POINT
4f4fe36 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
merge master
cd591e8
@dannygoldstein
fix hotpants import error
a3473af
@dannygoldstein
add scamp dependency
35c1559 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
add calibrate_astrometry to scamp.__all__
8ddf523 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
pep8
66c25c7 
Signed-off-by: Danny Goldstein <[email protected]>
@dannygoldstein
Merge branch 'master' into scamp
2aab1d8
@dannygoldstein
merge master into scamp
7a48673
@dannygoldstein
Copy link
Member

Thanks @Conor-Larison. Looking at the diff, I think this branch is missing a commit with the actual change we discussed (adding ERRX2_IMAGE, ERRY2_IMAGE). Can you do the following:

  • Create a new branch off of origin/master

  • Change the param.file as we discussed

  • Commit the change

  • Push the branch to your fork, and open a PR.

@dannygoldstein
Copy link
Member

@Conor-Larison You can either force-push this branch, or open a new PR. Your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Conor-Larison @dannygoldstein