Feature/Restore last opened files #159

miteshgoplani · 2020-07-18T15:33:46Z

This PR serves as a feature enhancement for Zlux Editor - Restore last openend files/datasets in Editor on next launch

Save file path on file/dataset open
Delete file path on file/dataset close
Restore last opened files/datasets on next launch

Dependent-on: zowe/zlux-app-manager#274

Signed-off-by: Mitesh Goplani [email protected]

…[email protected]> Signed-off-by: Mitesh <[email protected]>

Signed-off-by: Mitesh Goplani [email protected] Signed-off-by: Mitesh <[email protected]>

Signed-off-by: Mitesh <[email protected]>

1000TurquoisePogs · 2020-07-22T21:26:53Z

The concept works but there are some issues

GET before PUT is not needed because the editor knows the list of every tab that is open, so you can just PUT. Because you already have the events in the right place, I suggest you can just have an array within the editor-control file that you can add to & remove from when you open and close tabs, and then do a PUT on the result of the array. This way, no GET is needed! It will improve performance and reduce cpu use.
What to do when there are two editors open? Maybe saving should only work for the first one currently, because now it is weird that you get the same tabs twice.

Signed-off-by: Mitesh <[email protected]>

miteshgoplani · 2020-07-26T20:22:42Z

The concept works but there are some issues

GET before PUT is not needed because the editor knows the list of every tab that is open, so you can just PUT. Because you already have the events in the right place, I suggest you can just have an array within the editor-control file that you can add to & remove from when you open and close tabs, and then do a PUT on the result of the array. This way, no GET is needed! It will improve performance and reduce cpu use.

What to do when there are two editors open? Maybe saving should only work for the first one currently, because now it is weird that you get the same tabs twice.

Resolved the first issue
Working on the second one

Signed-off-by: Mitesh <[email protected]>

miteshgoplani · 2020-07-30T19:33:18Z

The concept works but there are some issues

GET before PUT is not needed because the editor knows the list of every tab that is open, so you can just PUT. Because you already have the events in the right place, I suggest you can just have an array within the editor-control file that you can add to & remove from when you open and close tabs, and then do a PUT on the result of the array. This way, no GET is needed! It will improve performance and reduce cpu use.

What to do when there are two editors open? Maybe saving should only work for the first one currently, because now it is weird that you get the same tabs twice.

For the second issue, added a window storage object activeZluxEditors which stores active editor windows count and if only one window is open fileRestore would work

webClient/src/app/app.component.ts

Signed-off-by: Mitesh <[email protected]>

webClient/src/app/app.component.ts

Signed-off-by: Mitesh <[email protected]>

webClient/src/app/shared/editor-control/editor-control.service.ts

Signed-off-by: Mitesh <[email protected]>

DivergentEuropeans

Great work so far. For some reason,
Save file path on file/dataset open
Delete file path on file/dataset close

this seemed to work for 1 time, and then stopped working? I wonder if it's related to my comment

However, saved tabs do indeed open back up.

DivergentEuropeans · 2020-08-25T18:04:29Z

webClient/src/app/app.component.ts

    this.log.debug(`Monaco object=`,monaco);
+    let openWindowsStorageString : string = window.localStorage.getItem("org.zowe.editor-openWindows")


You don't have to hardcode the plugin name. You can get this from the PLUGIN_DEFINITION

this.pluginDefinition.getBasePlugin().getIdentifier() should work

Okay, I'll use this

DivergentEuropeans · 2020-08-25T18:13:45Z

webClient/src/app/app.component.ts

+    dataToSave = activeZluxEditorsCount.toString() + ":" + Date.now() 
+    window.localStorage.setItem("org.zowe.editor-openWindows",dataToSave)
+    window.addEventListener("beforeunload", () => { 
+      activeZluxEditorsCount = +window.localStorage.getItem("org.zowe.editor-openWindows").split(":")[0]


Is this not a copy for what you do in NgOnDestroy? Don't they attempt to accomplish the same thing or do you need both?

Additionally, if you want to use the JS event listeners, you'll need to initialize them to a variable and manually removeEventListener() otherwise, they will continue existing until something else wipes them

Sometimes ngOnDestroy() for Editor is not called when we close the browser tab directly with the editor open.
So, to handle that case I was using JS event listener

miteshgoplani · 2020-08-26T08:46:45Z

Great work so far. For some reason,
Save file path on file/dataset open
Delete file path on file/dataset close

this seemed to work for 1 time, and then stopped working? I wonder if it's related to my comment

However, saved tabs do indeed open back up.

The editor would stop saving tabs when we have more than one instance of editor running in same/multiple windows
Was it the case when Save didn't occur?
@DivergentEuropeans

Signed-off-by: Mitesh <[email protected]>

DivergentEuropeans

Changes look good to me 🍨 (code) just need to test/QA this. Please reach out to @struga0258 if I don't get to it

1000TurquoisePogs

This looks good to me now so we'll just merge when automation has been written which is something that James and I are looking into who will be doing that.

DivergentEuropeans · 2021-05-07T18:52:20Z

Update: This PR is good, but doesn't address dealing with multiple Editor sessions and across multiple Desktops. It needs extending & may be groomed later by the team

Dismiss

miteshgoplani added 2 commits July 18, 2020 20:59

Create open tabs saving mechanism. Signed-off-by: Mitesh Goplani <mgo…

c28f789

…[email protected]> Signed-off-by: Mitesh <[email protected]>

Restore last opened files on next launch.

1424ded

Signed-off-by: Mitesh Goplani [email protected] Signed-off-by: Mitesh <[email protected]>

miteshgoplani force-pushed the fileRestore branch from 21491ba to 1424ded Compare July 18, 2020 17:15

miteshgoplani changed the title ~~[WIP] Create open tabs saving mechanism~~ Feature/Restore last opened files Jul 18, 2020

miteshgoplani added 2 commits July 22, 2020 18:44

Add Dataset Support

8ac3586

Signed-off-by: Mitesh <[email protected]>

Minor Fix

0980695

Signed-off-by: Mitesh <[email protected]>

Remove GET before PUT

a431435

Signed-off-by: Mitesh <[email protected]>

Add fileRestore support for multiple editor windows

485714c

Signed-off-by: Mitesh <[email protected]>

1000TurquoisePogs reviewed Jul 30, 2020

View reviewed changes

webClient/src/app/app.component.ts Outdated Show resolved Hide resolved

webClient/src/app/app.component.ts Outdated Show resolved Hide resolved

Add timestamp to storage string

cfd4a5b

Signed-off-by: Mitesh <[email protected]>

miteshgoplani requested a review from 1000TurquoisePogs July 31, 2020 13:53

miteshgoplani commented Jul 31, 2020

View reviewed changes

webClient/src/app/app.component.ts Outdated Show resolved Hide resolved

Update counter reset relation

63be2ff

Signed-off-by: Mitesh <[email protected]>

1000TurquoisePogs reviewed Aug 5, 2020

View reviewed changes

webClient/src/app/shared/editor-control/editor-control.service.ts Outdated Show resolved Hide resolved

miteshgoplani added 6 commits August 5, 2020 20:17

Update function name

54f554a

Signed-off-by: Mitesh <[email protected]>

Move code to constructor from ngOnInit

7c5762d

Signed-off-by: Mitesh <[email protected]>

Reduce Network Calls

e220b36

Signed-off-by: Mitesh <[email protected]>

Minor Update

5d4b70b

Signed-off-by: Mitesh <[email protected]>

Minor Update

a3fb654

Signed-off-by: Mitesh <[email protected]>

Small Bug Fix

990c1cc

Signed-off-by: Mitesh <[email protected]>

miteshgoplani requested a review from 1000TurquoisePogs August 12, 2020 15:30

Fix counter value initialisation bug

bc648f0

Signed-off-by: Mitesh <[email protected]>

DivergentEuropeans previously requested changes Aug 25, 2020

View reviewed changes

Add removeEmentListener and minor changes

dba95cb

Signed-off-by: Mitesh <[email protected]>

miteshgoplani requested a review from DivergentEuropeans August 29, 2020 09:46

DivergentEuropeans reviewed Sep 8, 2020

View reviewed changes

1000TurquoisePogs approved these changes Sep 17, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/Restore last opened files #159

Feature/Restore last opened files #159

miteshgoplani commented Jul 18, 2020 •

edited

Loading

1000TurquoisePogs commented Jul 22, 2020

miteshgoplani commented Jul 26, 2020

miteshgoplani commented Jul 30, 2020

DivergentEuropeans left a comment

DivergentEuropeans Aug 25, 2020

DivergentEuropeans Aug 25, 2020

miteshgoplani Aug 26, 2020

DivergentEuropeans Aug 25, 2020

DivergentEuropeans Aug 25, 2020

miteshgoplani Aug 26, 2020

miteshgoplani commented Aug 26, 2020 •

edited

Loading

DivergentEuropeans left a comment

1000TurquoisePogs left a comment

DivergentEuropeans commented May 7, 2021

		this.log.debug(`Monaco object=`,monaco);
		let openWindowsStorageString : string = window.localStorage.getItem("org.zowe.editor-openWindows")

Feature/Restore last opened files #159

Are you sure you want to change the base?

Feature/Restore last opened files #159

Conversation

miteshgoplani commented Jul 18, 2020 • edited Loading

1000TurquoisePogs commented Jul 22, 2020

miteshgoplani commented Jul 26, 2020

miteshgoplani commented Jul 30, 2020

DivergentEuropeans left a comment

Choose a reason for hiding this comment

DivergentEuropeans Aug 25, 2020

Choose a reason for hiding this comment

DivergentEuropeans Aug 25, 2020

Choose a reason for hiding this comment

miteshgoplani Aug 26, 2020

Choose a reason for hiding this comment

DivergentEuropeans Aug 25, 2020

Choose a reason for hiding this comment

DivergentEuropeans Aug 25, 2020

Choose a reason for hiding this comment

miteshgoplani Aug 26, 2020

Choose a reason for hiding this comment

miteshgoplani commented Aug 26, 2020 • edited Loading

DivergentEuropeans left a comment

Choose a reason for hiding this comment

1000TurquoisePogs left a comment

Choose a reason for hiding this comment

DivergentEuropeans commented May 7, 2021

miteshgoplani commented Jul 18, 2020 •

edited

Loading

miteshgoplani commented Aug 26, 2020 •

edited

Loading