Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show library datasets under correct library name #213

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

AndrewTwydell
Copy link
Contributor

@AndrewTwydell AndrewTwydell commented Jan 23, 2025

What It Does
Resolves #212 .

This changes the LibraryTreeItems to use a default filter of their Library name so only the Library datasets in that Library show up in that tree. Then it appends the active filter of the library to that filter to search the DSName attribute.

Resulting behaviour is only the library datasets with the correct library name show up under that tree, with the filter applying to the dsname attribute.

How to Test

Have multiple Library resources with different datasets in. Expand each library. Before this update, they would show the same datasets - now they should show correct datasets.

Review Checklist
I certify that I have:

Updated view with bug fixed.
Screenshot 2025-01-27 at 10 44 31 AM

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 28.56%. Comparing base (5049eeb) to head (364ccf6).

Files with missing lines Patch % Lines
...es/vsce/src/trees/treeItems/CICSLibraryTreeItem.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #213   +/-   ##
=======================================
  Coverage   28.55%   28.56%           
=======================================
  Files         147      147           
  Lines        5032     5031    -1     
  Branches      881      882    +1     
=======================================
  Hits         1437     1437           
+ Misses       3595     3594    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@almightyrush almightyrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙏

Copy link
Contributor

@davenice davenice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally - looks good.

@AndrewTwydell AndrewTwydell merged commit 2ba9565 into main Jan 27, 2025
19 checks passed
@AndrewTwydell AndrewTwydell deleted the fix-library-filters branch January 27, 2025 15:28
@AndrewTwydell AndrewTwydell added the release-patch Indicates a patch to existing code has been applied label Jan 27, 2025
Copy link

Release succeeded for the main branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-patch Indicates a patch to existing code has been applied released
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Library Tree shows all library datasets in all library tree items
4 participants