-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show library datasets under correct library name #213
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
=======================================
Coverage 28.55% 28.56%
=======================================
Files 147 147
Lines 5032 5031 -1
Branches 881 882 +1
=======================================
Hits 1437 1437
+ Misses 3595 3594 -1 ☔ View full report in Codecov by Sentry. |
4d38d6b
to
4b7e7ed
Compare
Signed-off-by: Andrew Twydell <[email protected]>
4b7e7ed
to
364ccf6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally - looks good.
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
Resolves #212 .
This changes the LibraryTreeItems to use a default filter of their Library name so only the Library datasets in that Library show up in that tree. Then it appends the active filter of the library to that filter to search the DSName attribute.
Resulting behaviour is only the library datasets with the correct library name show up under that tree, with the filter applying to the dsname attribute.
How to Test
Have multiple Library resources with different datasets in. Expand each library. Before this update, they would show the same datasets - now they should show correct datasets.
Review Checklist
I certify that I have:
Updated view with bug fixed.