-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using real data for unit test mocking #204
base: main
Are you sure you want to change the base?
Conversation
0397686
to
9d46311
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #204 +/- ##
=======================================
Coverage 28.25% 28.25%
=======================================
Files 146 146
Lines 4987 4987
Branches 869 869
=======================================
Hits 1409 1409
Misses 3578 3578 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good!
Great to use actual data.
We might find in the future we need to have specific data per test, rather than a generic set of mocks, but I imagine that the generic set will do us for a while!
85af963
to
2dc5377
Compare
@zFernand0 I'd like to run this by you, now that I've marked it ready for review - the only potential contentious point would be that I've changed the method we're mocking here. We're unit testing |
Signed-off-by: Andrew Twydell <[email protected]>
2dc5377
to
2378037
Compare
Signed-off-by: Andrew Twydell <[email protected]>
What It Does
Adapts SDK unit tests to use real CMCI responses for a more accurate behaviour.
Review Checklist
I certify that I have:
Additional Comments