Improve key commands #862
Merged
Improve key commands #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalrentka
approved these changes
Feb 29, 2024
mvasilak
force-pushed
the
improve-key-commands
branch
from
c356f79 to
0d341eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplements key commands to also display them in the HUD that appears when Command button is pressed in an iPad with an external keyboard.
Currently, if an arrow is pressed, to move to another page, PSPDFKit keyboard shortcuts will appear as such:
Those are suppresed with this PR.
Now by default these commands will appear:
If there is a back action available, those are added as well:
However, if an arrow is pressed, more edit commands will be added, but they are innocuous enough:
Only
Select Allworks to select all the text in the current page.