Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve status bar height initial value #838

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

mvasilak
Copy link
Contributor

@mvasilak mvasilak commented Feb 1, 2024

When the app state is restored to an open PDF document with a visible annotation toolbar, sometimes, due to the use of the extra UIWindow for the smoother instant presentation, there is not yet a foregroundActive connected scene, so statusBarHeight is set to 0, messing up the annotation toolbar placement.

You can reproduce this by:

  • opening a PDF document
  • show annotation toolbar
  • kill the app
  • launch app again (open document should be restored)

Fix moves the computation in viewDidLoad that allows an easier way to access the statusBarManager.

Also mentioned in this forum post

@mvasilak mvasilak requested a review from michalrentka February 1, 2024 13:53
@mvasilak mvasilak self-assigned this Feb 1, 2024
@mvasilak mvasilak merged commit b47f037 into zotero:master Feb 2, 2024
1 check passed
@mvasilak mvasilak deleted the fix-status-bar-height-value branch February 8, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants