Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PDFAnnotationsViewController edge case bug #1048

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

mvasilak
Copy link
Contributor

@mvasilak mvasilak commented Jan 4, 2025

Should fix issue reported in submitted crash

@michalrentka
Copy link
Contributor

Might be worth adding this fix to other reconfigure cases.

@mvasilak
Copy link
Contributor Author

mvasilak commented Jan 5, 2025

@michalrentka check 108c60c

@mvasilak mvasilak requested a review from michalrentka January 5, 2025 13:35
@michalrentka
Copy link
Contributor

@michalrentka check 108c60c

Sorry, I thought I already approved, didn't notice this update.

@mvasilak
Copy link
Contributor Author

mvasilak commented Jan 6, 2025

@michalrentka no worries, I asked for another quick look. Please, also see the commit just added. It's related to crashes received with objc_relase_x24

@mvasilak mvasilak merged commit dbdf62d into zotero:master Jan 6, 2025
1 check passed
@mvasilak mvasilak deleted the fix-bugs branch January 6, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants