Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow rendering of document annotations #1042

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

michalrentka
Copy link
Contributor

Fixes #1041

Copy link
Contributor

@mvasilak mvasilak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the same change be made to PDFReaderActionHandler.storeAnnotationPreviewsIfNeeded? Otherwise, an appearance change won't update the preview for document free text annotations.

@michalrentka
Copy link
Contributor Author

Shouldn't the same change be made to PDFReaderActionHandler.storeAnnotationPreviewsIfNeeded? Otherwise, an appearance change won't update the preview for document free text annotations.

Yeah I forgot that we checked there too, it's not even necessary, so I just removed those checks completely ce41b1c

@mvasilak mvasilak self-requested a review December 12, 2024 12:00
@michalrentka michalrentka merged commit 6f8e87d into zotero:master Dec 12, 2024
1 check passed
@michalrentka michalrentka deleted the preview_rendering_fix branch January 27, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Document free text annotation preview not loaded
2 participants