Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra logging for PDF database annotation author check #1037

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Add extra logging for PDF database annotation author check #1037

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Zotero/Scenes/Detail/PDF/Models/PDFDatabaseAnnotation.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,15 @@ struct PDFDatabaseAnnotation {
}

func isAuthor(currentUserId: Int) -> Bool {
return item.libraryId == .custom(.myLibrary) ? true : item.createdBy?.identifier == currentUserId
if item.libraryId == .custom(.myLibrary) {
return true
}
guard let user = item.createdBy else {
DDLogWarn("PDFDatabaseAnnotation: isAuthor for currentUserId: \(currentUserId) encountered nil user")
return false
}
DDLogInfo("PDFDatabaseAnnotation: isAuthor for currentUserId: \(currentUserId) compared to \(user.identifier)")
return user.identifier == currentUserId
}

func author(displayName: String, username: String) -> String {
Expand Down