Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug when attachment would be disabled after opening with navbar button #1036

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Fixed bug when attachment would be disabled after opening with navbar button #1036

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Zotero/Scenes/Detail/ItemDetail/Views/ItemDetailViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,12 @@ final class ItemDetailViewController: UIViewController {
}
}

if state.attachmentToOpen == nil {
// Reset this flag in case the attachment has been opened already (happens when attachment was already downloaded, this is set to true when trying to open, but is not set to false when
// it opens without download).
downloadingViaNavigationBar = false
}

/// Updates navigation bar with appropriate buttons based on editing state.
/// - parameter isEditing: Current editing state of tableView.
func setNavigationBarButtons(to state: ItemDetailState) {
Expand Down