Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PDF reader items observer #1027

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Improve PDF reader items observer #1027

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Zotero/Scenes/Detail/PDF/ViewModels/PDFReaderActionHandler.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1833,7 +1833,7 @@ final class PDFReaderActionHandler: ViewModelActionHandler, BackgroundDbProcessi
}

func observe(items: Results<RItem>, viewModel: ViewModel<PDFReaderActionHandler>, handler: PDFReaderActionHandler) -> NotificationToken {
return items.observe { [weak handler, weak viewModel] change in
return items.observe(keyPaths: [\RItem.changeType]) { [weak handler, weak viewModel] change in
guard let handler, let viewModel else { return }
switch change {
case .update(let objects, let deletions, let insertions, let modifications):
Expand Down