Improve PDFWorkerController & RecognizerController relay bindings

zotero · Feb 26, 2025 · ec93630 · ec93630
1 parent f5dcb15
commit ec93630
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/Zotero/Controllers/PDFWorkerController.swift b/Zotero/Controllers/PDFWorkerController.swift
@@ -73,8 +73,7 @@ final class PDFWorkerController {
         accessQueue.async(flags: .barrier) { [weak self] in
             guard let self else { return }
             if let existingSubject = subjectsByPDFWork[work] {
-                existingSubject.subscribe(subject)
-                    .disposed(by: disposeBag)
+                existingSubject.bind(to: subject).disposed(by: disposeBag)
                 return
             }
             queue[work] = subject

diff --git a/Zotero/Controllers/RecognizerController.swift b/Zotero/Controllers/RecognizerController.swift
@@ -148,12 +148,12 @@ final class RecognizerController {
         accessQueue.async(flags: .barrier) { [weak self] in
             guard let self else { return }
             if let existingSubject = subjectsByTask[task] {
-                existingSubject.subscribe(subject)
-                    .disposed(by: disposeBag)
+                existingSubject.bind(to: subject).disposed(by: disposeBag)
                 return
             }
             queue[task] = subject
             statesByTask[task] = .enqueued
+            subject.bind(to: updatesSubject).disposed(by: disposeBag)
 
             emmitUpdate(for: task, subject: subject, kind: .enqueued)
             startRecognitionIfNeeded()
@@ -169,7 +169,6 @@ final class RecognizerController {
             latestUpdates[libraryId] = libraryLatestUpdates
         }
         subject.on(.next(update))
-        updatesSubject.on(.next(update))
     }
 
     private func startRecognitionIfNeeded() {