Improve pdf document search (#860)

* Improve PDFSearchViewController keyboard dismiss mode * In PDFSearchViewController dismiss keyboard on search button click
zotero · Feb 27, 2024 · cf5a6cc · cf5a6cc
1 parent 84450c6
commit cf5a6cc
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/Zotero/Scenes/Detail/PDF/Views/PDFSearchViewController.swift b/Zotero/Scenes/Detail/PDF/Views/PDFSearchViewController.swift
@@ -64,14 +64,16 @@ final class PDFSearchViewController: UIViewController {
             tableView.translatesAutoresizingMaskIntoConstraints = false
             tableView.dataSource = self
             tableView.delegate = self
-            tableView.keyboardDismissMode = UIDevice.current.userInterfaceIdiom == .pad ? .none : .interactive
+            tableView.keyboardDismissMode = UIDevice.current.userInterfaceIdiom == .pad ? .none : .onDrag
             tableView.register(UINib(nibName: "PDFSearchCell", bundle: nil), forCellReuseIdentifier: PDFSearchViewController.cellId)
             view.addSubview(tableView)
             self.tableView = tableView
 
             let searchBar = UISearchBar()
             searchBar.translatesAutoresizingMaskIntoConstraints = false
             searchBar.placeholder = L10n.Pdf.Search.title
+            // Set search bar delegate before reactive extension, otherwise reactive will be overwritten.
+            searchBar.delegate = self
             searchBar.rx
                 .text
                 .observe(on: MainScheduler.instance)
@@ -202,3 +204,9 @@ extension PDFSearchViewController: TextSearchDelegate {
         searchBar.isLoading = false
     }
 }
+
+extension PDFSearchViewController: UISearchBarDelegate {
+    func searchBarSearchButtonClicked(_ searchBar: UISearchBar) {
+        searchBar.resignFirstResponder()
+    }
+}