-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated multipart argument memfile_limit with spool_limit #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good if we make sure setup.py requires multipart >= the version that added the spool_limit
argument. What version was it, by the way?
(You'll want to rebase on git master to fix the CI failure.) |
I found a button on GitHub that allowed me to rebase your branch. Hope I didn't step on any toes while doing it! |
Thanks for the review. I will update the setup.py 👍
The bump to multipart v1.0.0 |
Thank you for your contribution. According to the contributing policies of the zopefoundation organization you need to sign a contributor agreement before any non-trivial change can be merged. For details please consult the Contributing guidelines for zopefoundation projects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the changes, additionally I'd like to request an entry in the change log.
@icemac Updated changelog and signed agreement 👍 |
Thank you for this PR. 😃 And welcome onboard! |
Hello everyone,
memfile_limit
has been replaced byspool_limit
, see https://github.com/defnull/multipart/blob/master/multipart.py#L576.Unfortunately they use
self.spool_limit = memfile_limit or spool_limit
, so ifmemfile_limit = 0
it will always be the defaultspool_limit
instead.