Add HTML5 boolean attributes to the list #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icemac
approved these changes
Aug 6, 2024
|
Thank you for this PR. The broken tests seem to be unrelated to your changes, I will take care of them. |
|
The breakage induced in |
|
I have restarted the failed jobs, which should be fixed by the release of |
|
@tseaver Thank you for fixing this so quickly. |
|
@cillianderoiste Released as https://pypi.org/project/z3c.pt/4.4/ |
|
Fantastic, thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when rendering a video element,
tal:attributes="autoplay python:''"was rendering as autoplay='' which is treated as a positive value in the browser, enabling autoplay. By extending the list of boolean HTML attributes, the attribute is now dropped when empty.I've included all the boolean attributes, and kept the old attributes, to maintain backwards compatibility.
Here's a list of all HTML5 boolean attributes, derived from https://html.spec.whatwg.org/multipage/indices.html#attributes-3
allowfullscreen
async
autofocus
autoplay
checked
controls
default
defer
disabled
formnovalidate
inert
ismap
itemscope
loop
multiple
muted
nomodule
novalidate
open
playsinline
readonly
required
reversed
selected
shadowrootclonable
shadowrootdelegatesfocus
shadowrootserializable