Modification to be able to handle quadruple repetitions #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dataflake
requested changes
Mar 1, 2025
| @@ -82,11 +82,11 @@ def toRoman(n): | |||
| romanNumeralPattern = re.compile(""" | |||
| ^ # beginning of string | |||
| M{0,4} # thousands - 0 to 4 M's | |||
| (CM|CD|D?C{0,3}) # hundreds - 900 (CM), 400 (CD), 0-300 (0 to 3 C's), | |||
| (CM|CD|D?C{0,4}) # hundreds - 900 (CM), 400 (CD), 0-300 (0 to 3 C's), | |||
There was a problem hiding this comment.
Wherever you make changes in the pattern you must change the comment that describes it because that's now wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are often not considered "standard" Roman numerals, but quadruple repetitions, such as in VIIII (instead of IX) do in fact appear since the first attestation, and are quite commonplace in some context.