Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Zope documentation sources for Zope 5 #738

Merged
merged 3 commits into from
Nov 29, 2019
Merged

Updated Zope documentation sources for Zope 5 #738

merged 3 commits into from
Nov 29, 2019

Conversation

dataflake
Copy link
Member

Fixes #659

Rearrange and update the general documentation (not the books, those are tracked in #252 and #671 already)

  • make "What's New" into a toplevel page with subsections for major versions
  • create a toplevel section for migrations with subsections for major versions
  • fold the WSGI page into the configuration documentation
  • update old version numbers where needed
  • rename addzope2user console script to addzopeuser

@dataflake dataflake added this to the 5.0 milestone Nov 28, 2019
@dataflake dataflake requested review from icemac and jugmac00 November 28, 2019 19:34
@dataflake dataflake self-assigned this Nov 28, 2019
Copy link
Member

@jugmac00 jugmac00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking your time for this!

I like the changes.

There was one minor thing which confused me at first.

When you click on "Migrating between Zope versions", the tree with sub bullet points is fully expanded (all levels are expanded).

But when you click on "Migrating from Zope 2 to Zope 4 or 5" the tree gets partially collapsed.

I'd suggest that the tree stays expanded (Or even swap the behavior and on the top level show only the top sub-levels, and expand more when you drill deeper).

I am not sure if I could express clearly.

Example
on top level you see this

a
  b1
    c1
       d1
       d2
    c2
  b2
  b3

When you drill deeper, you see less details.

b1
  c1
  c2
b2
b3

Usually, this is vice versa.
Screenshot from 2019-11-29 12-11-29
Screenshot from 2019-11-29 12-11-33

@dataflake
Copy link
Member Author

You're right, I noticed menu trees that did not explicityly specify the maximum depth. It's changed to be consistent now.

@dataflake dataflake merged commit cc17001 into master Nov 29, 2019
@dataflake dataflake deleted the issue_659 branch November 29, 2019 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation to Zope 5
2 participants