Fix Content-Disposition header for clients without rfc6266 support #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since zopefoundation#893 the Content-Disposition header supports non-ascii filenames, by containing the filename in ascii and the filename in UTF-8, but the ascii version was produced by applying `str` on a `bytes` instance, so it looks like `b'file.txt'` instead of `file.txt`.
perrinjerome
force-pushed
the
fix/content-disposition-filename
branch
from
71e849c to
7f4c61c
Compare
perrinjerome
changed the title
perrinjerome
changed the title
d-maurer
approved these changes
Feb 17, 2024
dataflake
approved these changes
Feb 19, 2024
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #893 the Content-Disposition header supports non-ascii filenames, by containing the filename in ascii and the filename in UTF-8, but the ascii version was produced by applying
stron abytesinstance, so it looks likeb'file.txt'instead offile.txt.