refactor(drawing-tools): revert non-scaling-size #6689
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vector-effect: non-scaling-size
isn't implemented in browsers, so this reverts it back tonon-scaling-stroke
in drag handles, point marks, and transcription lines.Test cases in the dev classifier:
This PR shouldn't change how drawn marks are rendered at all. Points and drag handles should remain the same size and width, regardless of image zoom level.
Here's a quick codepen which draws two identical SVG circles, one with 'non-scaling-stroke' and one with 'non-scaling-size'. Stroke scaling is only ignored in the first. The SVG spec says that it should be ignored in both.
https://codepen.io/eatyourgreens/pen/ZYEYqEv
If you resize the SVG image, by resizing the browser window, you'll see that the righthand circle gets thicker or thinner, but the lefthand circle remains the same.
Please request review from
@zooniverse/frontend
team or an individual member of that team.Package
Checklist
PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.
General
yarn panic && yarn bootstrap
ordocker-compose up --build
and FEM works as expectedGeneral UX
Example Staging Project: i-fancy-cats
Refactoring