-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump engine.io-client from 6.5.3 to 6.6.0 #6305
build(deps): bump engine.io-client from 6.5.3 to 6.6.0 #6305
Conversation
Bumps [engine.io-client](https://github.com/socketio/engine.io-client) from 6.5.3 to 6.6.0. - [Release notes](https://github.com/socketio/engine.io-client/releases) - [Changelog](https://github.com/socketio/engine.io-client/blob/6.6.0/CHANGELOG.md) - [Commits](socketio/engine.io-client@6.5.3...6.6.0) --- updated-dependencies: - dependency-name: engine.io-client dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
@mcbouslog this package was added in #2575 to build notifications, but I don't see |
The quick answer is that it's a strange situation where |
At minimum I could add a comment where the sugarClient is imported, I could also investigate updating PJC to include |
Thanks! I suggest just adding an inline comment. For instance, if I search all of FEM for keyword "engine.io" then at least there'd be a bit of documentation so future devs don't accidentally remove the package. Feel free to take over this dependabot PR and add to it if easiest! You should be able to approve and merge it without additional review. |
@goplayoutside3 @mcbouslog If you're bumping the web sockets client to 6.6, you'll also need to bump the server to 6.6. See zooniverse/sugar#347. |
Bumps engine.io-client from 6.5.3 to 6.6.0.
Release notes
Sourced from engine.io-client's releases.
... (truncated)
Changelog
Sourced from engine.io-client's changelog.
Commits
a17cbc5
chore(release): 6.6.072408ad
docs(changelog): include release notes from versions 3.5.3, 3.5.4 and 6.5.4e97a4d3
chore: bump ws from 8.11.0 to 8.17.1 (#720)b624c50
fix: add some randomness to the cache busting string generatorc087dc5
docs(changelog): include the size of the bundlece13763
ci: upgrade to actions/checkout@4 and actions/setup-node@474cfb98
refactor: prefix private attributes to allow property mangling2b9abbb
chore: restore the debug package in the dev bundlee105551
fix: fix cookie management with WebSocket (Node.js only)3f66478
chore: remove unused rollup pluginDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)