Restore outputRelativePath functionality #121
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #95
It looks like the
outputRelativePath
option was removed in this commit: 29e7cccThe
createFile
function before:and after
I'm not familiar with the overall design/architecture here, but this was my best guess as to how to restore the functionality. The
createFile
function currently only handles the HTML templates/views, so re-adding the code there would not actually modify the output directory of the asset files.Based on the description of
outputRelativePath
("Relative location to html file for new concatenated js and css."), it seemed the best place for the value was in thename
property of the blocks, which is passed as the first argument togulp-concat
here.If someone who is familiar with the repo could take a look and review that'd be great! I could write some tests, though a lot of the tests were failing locally for me already so not sure how maintained the tests are? (or if that was some issue with my local setup).
Also, there is already a PR regarding
outputRelativePath
here but it modifies the old behavior before that refactor commit above. It looks like there were unanswered questions as to how exactlyoutputRelativePath
should work that are probably worth addressing.