Add banner video #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emily40830
reviewed
Nov 20, 2023
| } | ||
| .col-1-2,.col-1-3,.col-1-4{ | ||
| border: 1px solid red; | ||
| float: left; |
There was a problem hiding this comment.
floats 在目前前端已經非常少在使用了
可以改用 flexbox 作為網頁佈局的方式
emily40830
reviewed
Nov 20, 2023
Comment on lines
+20
to
+21
| <a href="#!" class="nav-link">首頁</a> | ||
| </li> |
There was a problem hiding this comment.
如果連結是暫時的或未定的，建議使用 href="javascript:void(0);" 而不是 href="#!"。這樣可以防止頁面跳轉到頂部或出現未預期的行為
emily40830
reviewed
Nov 20, 2023
Comment on lines
+14
to
+21
| <div id="navbar" class="navbar"> | ||
| <a href="#!" class="brand"> | ||
| <h1>漫威電影與劇集 | Disney+</h1> | ||
| </a> | ||
| <ul class="nav"> | ||
| <li class="nav-item"> | ||
| <a href="#!" class="nav-link">首頁</a> | ||
| </li> |
There was a problem hiding this comment.
改用 BEM 命名方式重構
- brand -> navbar__brand
- nav -> navbar__nav
- nav-item -> navbar__item
- nav-link -> navbar__link
emily40830
reviewed
Nov 20, 2023
|
|
||
| <!-- Start jumbotron --> | ||
| <div class="jumbotron"> | ||
| <div class="mask-dark"></div> |
There was a problem hiding this comment.
改用 BEM 命名 classname
mask-dark -> jumbotron__mask-dark
emily40830
reviewed
Nov 20, 2023
Comment on lines
+76
to
+81
|
|
||
| abbr[title] { | ||
| border-bottom: none; /* 1 */ | ||
| text-decoration: underline; /* 2 */ | ||
| text-decoration: underline dotted; /* 2 */ | ||
| } |
There was a problem hiding this comment.
這段在 normalize.css 也出現過了
需移掉
也需要檢查有沒有重複定義的 css 樣式
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.