Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extra validator for maimai DX score verification #963

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

j1nxie
Copy link
Contributor

@j1nxie j1nxie commented Oct 18, 2023

checked up with a few friends and 100.5% seems to be the minimum for an ALL PERFECT score, so adding it as a validator for scores.

there isn't a validator for the other way around since scores higher than 100.5% can be not ALL PERFECT.

@zkrising
Copy link
Owner

zkrising commented Oct 18, 2023

can you explain the maths behind this? if it's always the case for now and every future chart, then yeah

@beer-psi
Copy link
Contributor

To put simply, the 101% in maimai DX scores is split into 2 parts: 100% base score and 1% break bonus.

All note types (tap, hold, slide, touch, break) award full base scores on PERFECTs, no surprises here.

However, break bonus varies based on how precise a break note was hit, with the minimum bonus for a PERFECT hit being half of full bonus.

Assuming all breaks were hit with minimum bonus, that leaves us with 1 / 2 = 0.5% break bonus => 100.5% score being the minimum for ALL PERFECTs.

This doesn't apply the other way around (100.5+ does not mean an ALL PERFECT) because you could get higher break bonuses and use that to tank the losses from hitting non-perfects.

More details on the maimai DX scoring system: https://github.com/SpiritsUnite/maimai-score-details#maimai-scoring-system

@zkrising
Copy link
Owner

what if a chart has no breaks?

@beer-psi
Copy link
Contributor

all official charts are guaranteed to have at least one break, it's been 10 years of maimai and no charts with zero breaks exist.

@j1nxie
Copy link
Contributor Author

j1nxie commented Oct 18, 2023

to be fair, we support only official charts from SEGA, which will clearly guarantee at least 1 break note, due to the fact that the game checks for 101% for ALL PERFECT+ lamps. in which case, 100.5% being the minimum for ALL PERFECT will also apply.

@zkrising
Copy link
Owner

ok, but what happens if there was a chart with no breaks in the future?

@j1nxie
Copy link
Contributor Author

j1nxie commented Oct 18, 2023

then at that point, fuck SEGA, and we might have to drop all the validators at that point, since if that was the case the max score would be 100% and AP+ validation would be removed too.

@zkrising
Copy link
Owner

i think it's more likely that in the 0 breaks case you end up with +1% for breaks no matter what. has anyone actually tested this is what i'm getting at

@zkrising
Copy link
Owner

bad news: no breaks => 100% max. technically speaking maimaidx has a chart dependent max, but do we care? do you care? i don't. sega don't care either. nobody cares.

@zkrising zkrising merged commit a4e8b0d into zkrising:staging Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants