Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New match type: ddrSongHash #1213

Merged
merged 6 commits into from
Dec 18, 2024
Merged

New match type: ddrSongHash #1213

merged 6 commits into from
Dec 18, 2024

Conversation

tranq88
Copy link
Contributor

@tranq88 tranq88 commented Dec 4, 2024

ddrSongHash is a 32-character hash used by the official DDR e-amusement website to identify a song.

I believe Tachi supported this match type in the past but I didn't look too much into it. Re-implementing this will allow users to use services that scrape DDR scores from e-amusement, such as 3icecream (however their timestamps can be unreliable; I'm working on my own tool as well).

I tried my best to figure it out without official documentation. If anything's missing, please advise!

Copy link
Owner

@zkrising zkrising left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some small fixes/justifications before I'm willing to merge, but otherwise looks good. Thank you.

seeds/scripts/test/match-type.test.ts Outdated Show resolved Hide resolved
@nyairobi
Copy link
Contributor

It may be a good idea to mention it in the docs before we forget

There are leftover references to the previous ddrSongHash implementation, funnily enough

| `matchType` | "songTitle" \| "ddrSongHash" \| "tachiSongID" \| "bmsChartHash" \| "inGameID" \| "uscChartHash" | This determines how `identifier` will be used to match your scores' chart with Tachi's database of songs and charts. |
and
| `difficulty` (Conditional) | String | If `matchType` is "tachiSongID", "inGameID", "ddrSongHash" or "songTitle", this field must be present, and describe the difficulty of the chart this score is for. |

@tranq88 tranq88 requested a review from zkrising December 14, 2024 12:16
@zkrising zkrising merged commit 2111782 into zkrising:main Dec 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants