Skip to content

Commit

Permalink
fix: why isn't this an error?
Browse files Browse the repository at this point in the history
  • Loading branch information
zkrising committed Jul 7, 2024
1 parent 54f9701 commit 74c8a1a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions server/src/server/server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,6 @@ interface ExpressJSONErr extends SyntaxError {
}

const MAIN_ERR_HANDLER: express.ErrorRequestHandler = (err, req, res, _next) => {
logger.info(`MAIN_ERR_HANDLER hit by request.`, { url: req.originalUrl });

// this use of instanceof is fine.
// eslint-disable-next-line cadence/no-instanceof
if (err instanceof SyntaxError) {
Expand All @@ -200,6 +198,8 @@ const MAIN_ERR_HANDLER: express.ErrorRequestHandler = (err, req, res, _next) =>
// else, this isn't a JSON parsing error
}

logger.error(`MAIN_ERR_HANDLER hit by request.`, { url: req.originalUrl, body: req.body });

const unknownErr = err as unknown;

if (IsRecord(unknownErr) && unknownErr.type === "entity.too.large") {
Expand Down

0 comments on commit 74c8a1a

Please sign in to comment.