feat: get rid of isHot and isLatest in code (#1066)

* feat: get rid of isHot and isLatest in code * feat: remove hot/latest from seeds * feat: migrate away from them too * fix: 21 * fix: again * fix: again * fix: again
zkrising · May 10, 2024 · 5128581 · 5128581
1 parent 8fca6ef
commit 5128581
Show file tree

Hide file tree

Showing 27 changed files with 7,832 additions and 22,107 deletions.
diff --git a/client/src/components/tables/cells/DifficultyCell.tsx b/client/src/components/tables/cells/DifficultyCell.tsx
@@ -76,14 +76,6 @@ export default function DifficultyCell({
 				{FormatDifficultyShort(chart, game)}
 			</div>
 			<DisplayLevelNum game={game} level={chart.level} levelNum={chart.levelNum} />
-			{(("isHot" in chart.data && chart.data.isHot) ||
-				("isLatest" in chart.data && chart.data.isLatest)) && (
-				<QuickTooltip tooltipContent="This chart is from the latest version of the game!">
-					<div>
-						<Icon type="fire" />
-					</div>
-				</QuickTooltip>
-			)}
 			{!noTierlist && gptImpl.ratingSystems.length > 0 && (
 				<RatingSystemPart chart={chart} game={game} />
 			)}

diff --git a/common/src/config/game-support/gitadora.ts b/common/src/config/game-support/gitadora.ts
@@ -8,9 +8,7 @@ import type { INTERNAL_GAME_CONFIG, INTERNAL_GAME_PT_CONFIG } from "../../types/
 export const GITADORA_CONF = {
 	name: "GITADORA",
 	playtypes: ["Gita", "Dora"],
-	songData: z.strictObject({
-		isHot: z.boolean(),
-	}),
+	songData: z.strictObject({}),
 } as const satisfies INTERNAL_GAME_CONFIG;
 
 const GitadoraColours = [
@@ -71,9 +69,6 @@ export const GITADORA_GITA_CONF = {
 		skill: { description: "The average of your best 10 skill ratings this session." },
 	},
 	profileRatingAlgs: {
-		skill: {
-			description: "Your profile skill as it's implemented in game -- 25 HOT and 25 not HOT.",
-		},
 		naiveSkill: {
 			description:
 				"Your best 50 skill levels added together, regardless of whether the chart is HOT or not.",
@@ -82,7 +77,7 @@ export const GITADORA_GITA_CONF = {
 
 	defaultScoreRatingAlg: "skill",
 	defaultSessionRatingAlg: "skill",
-	defaultProfileRatingAlg: "skill",
+	defaultProfileRatingAlg: "naiveSkill",
 
 	difficulties: {
 		type: "FIXED",

diff --git a/common/src/config/game-support/maimai-dx.ts b/common/src/config/game-support/maimai-dx.ts
@@ -151,11 +151,6 @@ export const MAIMAI_DX_SINGLE_CONF = {
 			description: "A naive rating algorithm that just sums your 50 best scores.",
 			formatter: NoDecimalPlace,
 		},
-		rate: {
-			description:
-				"Rating as it's implemented in game, taking 15 scores from the latest version and 35 from all old versions.",
-			formatter: NoDecimalPlace,
-		},
 	},
 
 	defaultScoreRatingAlg: "rate",
@@ -215,9 +210,7 @@ export const MAIMAI_DX_SINGLE_CONF = {
 		buddies: "BUDDiES",
 	},
 
-	chartData: z.strictObject({
-		isLatest: z.boolean(),
-	}),
+	chartData: z.strictObject({}),
 
 	preferences: z.strictObject({}),
 	scoreMeta: z.strictObject({}),

diff --git a/common/src/config/game-support/wacca.ts b/common/src/config/game-support/wacca.ts
@@ -98,10 +98,6 @@ export const WACCA_SINGLE_CONF = {
 		naiveRate: {
 			description: "A naive rating algorithm that just sums your 50 best scores.",
 		},
-		rate: {
-			description:
-				"Rating as it's implemented in game, taking 15 scores from the latest version and 35 from all old versions.",
-		},
 	},
 	sessionRatingAlgs: {
 		rate: { description: "The average of your best 10 ratings this session." },
@@ -141,7 +137,6 @@ export const WACCA_SINGLE_CONF = {
 	},
 
 	chartData: z.strictObject({
-		isHot: z.boolean(),
 		inGameID: zodNonNegativeInt,
 	}),