Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI, cache compiled toml and uniffi-bindgen #82

Merged
merged 6 commits into from
Feb 27, 2024
Merged

Fix CI, cache compiled toml and uniffi-bindgen #82

merged 6 commits into from
Feb 27, 2024

Conversation

vivianjeng
Copy link
Collaborator

@vivianjeng vivianjeng commented Feb 26, 2024

@vivianjeng vivianjeng requested a review from oskarth February 26, 2024 13:08
@vivianjeng vivianjeng mentioned this pull request Feb 26, 2024
@oskarth
Copy link
Collaborator

oskarth commented Feb 27, 2024

Awesome, thank you!

@oskarth oskarth merged commit 6738296 into main Feb 27, 2024
6 checks passed
- uses: actions/checkout@v3
- name: Get uniffi-version
if: steps.toml-linux-restore.outputs.cache-hit == 'true'
run: echo "UNIFFI_VERSION=$(toml get mopro-ffi/Cargo.toml dependencies.uniffi.version -r)" >> $GITHUB_ENV
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making use of toml I see :D

# Print appropriate message based on device type
print_action "Using $ARCHITECTURE libmopro_ffi.a ($LIB_DIR) static library..."
print_warning "This only works on $FOLDER devices!"

print_action "[android] Build target in $BUILD_MODE mode"
cargo build --lib ${COMMAND} --target ${ARCHITECTURE}
cargo ndk -t ${ARCHITECTURE} build --lib ${COMMAND}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh interesting

@vivianjeng vivianjeng deleted the fix-ci branch February 27, 2024 02:50
@oskarth oskarth mentioned this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants