Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios): added basic UI in MSM Benchmark #71

Merged
merged 6 commits into from
Feb 22, 2024
Merged

feat(ios): added basic UI in MSM Benchmark #71

merged 6 commits into from
Feb 22, 2024

Conversation

FoodChain1028
Copy link
Collaborator

@FoodChain1028 FoodChain1028 commented Feb 13, 2024

Integrating MSM benchmark on IOS

we are aiming to integrate the previous work into IOS Example project

This PR closed #21

TODO Log

iOS

  • Design the way to illustrate the benchmark of this
    • A swift file that maps all algorithm from uniffi to swift. Make it the only file we need to change if added a new algorithm.
    • A swift file for UI
      • A component to show the integrated algorithm
      • Rendering the mapped algorithm and wrapped it into components
      • A button component for "Generating Benchmarks"
    • A swift file for report generating logic
      • show a table for (num_msm)

        Algorithm Avg Timing Compare to baseline
        (arkwork-msm)
        arkworks-msm in ms -
        Algo. A in ms in %
        Algo. B in ms in %
      • [Backlog] show a figure

Link

@FoodChain1028 FoodChain1028 changed the title feat(ios): added basic UI in MSM Benchmark WIP: feat(ios): added basic UI in MSM Benchmark Feb 13, 2024
@moven0831
Copy link
Collaborator

laptop
(Rust test)
laptop
(Swift test)
iOS Simulator
Demo Video
iPhone
Demo Video
Timing
(Single Arkworks MSM)
0.33 ms 0.37 ms 0.31 ms 0.27 ms
Device Spec M2 chip M2 chip M2 chip iPhone 14 Pro
(A16 Bionic)
Screenshots
(Click to enlarge)
MSM Rust test MSM Swift test MSM iOS Simulator [MSM iPhone 14 pro]

The report of this PR can be found here: https://hackmd.io/@FoodChain/rk3iyg3da

@FoodChain1028 FoodChain1028 changed the title WIP: feat(ios): added basic UI in MSM Benchmark feat(ios): added basic UI in MSM Benchmark Feb 21, 2024
@FoodChain1028 FoodChain1028 marked this pull request as ready for review February 21, 2024 11:50
Copy link
Collaborator

@oskarth oskarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good. Only thing is that CI is failing for iOS, not sure why.

(Android fails but this is expected, iOS should work in main though)

@moven0831
Copy link
Collaborator

I've re-run the workflow for the failed tests, and the part that previously stalled (circom installation) has successfully completed this time. I'll send a review request once the iOS test finishes.

@moven0831 moven0831 requested a review from oskarth February 22, 2024 06:48
@oskarth oskarth merged commit a9376db into zkmopro:main Feb 22, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement micro benchmarking tooling for doing MSMs/using GPU on Mobile
3 participants