Added config file for CLI #282
Conversation
Deploying mopro with
|
| Latest commit: |
02abf6a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b6cced98.mopro.pages.dev |
| Branch Preview URL: | https://cli-config.mopro.pages.dev |
|
I assumed that users will not manually remove the *Bindings folder in the initialized project created with |
cli/src/create.rs
Outdated
| // Adding more information on the list | ||
| let requires = ["ios", "android"]; | ||
| let missing: Vec<&str> = requires | ||
| .iter() | ||
| .filter(|&&req| !config.target_platforms.contains(req)) | ||
| .cloned() | ||
| .collect(); | ||
|
|
||
| if !missing.is_empty() { | ||
| items.push(format!( | ||
| "{:<12} - Requires {} binding(s)", | ||
| template, | ||
| missing.join("/") | ||
| )); | ||
| unselectable.push(true); | ||
| continue; | ||
| } |
There was a problem hiding this comment.
I created the two bindings separately (ios and android)
and the Config.toml is updated correctly
but the mopro create for react-native and flutter still shows Require binding
Please check this
cli/src/create.rs
Outdated
| continue; | ||
| } | ||
| } | ||
|
|
||
| if config.target_platforms.contains(template) { | ||
| items.push(template.to_string()); | ||
| unselectable.push(false); | ||
| } else { | ||
| items.push(format!("{:<12} - Require binding", template)); | ||
| unselectable.push(true); | ||
| } |
There was a problem hiding this comment.
I found the correct logic is like this
You should display the result of react-native and flutter if it is selectable
| continue; | |
| } | |
| } | |
| if config.target_platforms.contains(template) { | |
| items.push(template.to_string()); | |
| unselectable.push(false); | |
| } else { | |
| items.push(format!("{:<12} - Require binding", template)); | |
| unselectable.push(true); | |
| } | |
| // continue; | |
| } else { | |
| items.push(template.to_string()); | |
| unselectable.push(false); | |
| } | |
| } else if config.target_platforms.contains(template) { | |
| items.push(template.to_string()); | |
| unselectable.push(false); | |
| } else { | |
| items.push(format!("{:<12} - Require binding", template)); | |
| unselectable.push(true); | |
| } |
I believe the term 'framework' doesn't fit well in the 'build' phase. We've been using the term 'template' in the 'create' phase, so I decided to keep 'template' for printout strings in the 'create' phase while using 'framework' in the code for consistency. |
Related issue #264
Config.tomlwhenmopro initmopro buildandmopro createThe template selection is more informative like one below: