feat(core): update read_zkey with new_unchecked
#129
Conversation
|
I wonder if we want to combine ark-zkey with this? Because with ark-zkey we get 50% file size reduction due to point compression. |
| // read_zkey(&mut reader).expect("Failed to read zkey") | ||
| // }); | ||
|
|
||
| static ARKZKEY: Lazy<(ProvingKey<Bn254>, ConstraintMatrices<Fr>)> = Lazy::new(|| { |
There was a problem hiding this comment.
do we have to remove the ARKZKEY stuff you think? or is this preferable?
thinking mostly about space savings which are quite significant
|
If we remove/don't update arkzkey stuff, could we create an issue explaining problem and current state? So even if we don't do it now we can introduce this for arkzkey too |
|
I think we can create the issue to describe the situation I think arkzkey is still doable without the current serialization/deserialization but I am figuring out what is the correct way to serialize/deserialize |
|
Create an issue here |
According to #25 (comment)
new_unchecked