Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix npm_install script if there is no package.json #125

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

vivianjeng
Copy link
Collaborator

  • for multiplier.circom, there is no package.json so it throws error.
  • In prepare.sh we can check if there is a package.json file then execute npm install

@vivianjeng vivianjeng requested a review from oskarth April 5, 2024 04:10
Copy link
Collaborator

@oskarth oskarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhm right, good catch

@oskarth oskarth merged commit 8d619ba into main Apr 5, 2024
6 checks passed
@oskarth oskarth deleted the fix-prepare-cli branch April 5, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants