fix spending of immature coinbase utxos #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… funds in note selection
|
I'm not convinced that we should add this workaround, if it's just to support the edge case of receiving transparent coinbase transactions. I appreciate the effort, but maybe we should prioritize mining-to-orchard in zebrad instead. |
|
I stand corrected. I misunderstood the purpose. Would this change be stable across the pepper-sync integration, if it landed? |
|
yes but we actually will not need to port this to 2.0 as it will have a better solution to this issue and will not be using this transparent output type anyway |
pacu
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.