add flags to log output on stdout & disk (#208)

Co-authored-by: suv <suv@marketlogicsoftware.com>
zilliztech · Aug 13, 2021 · 8c5fb01 · 8c5fb01
1 parent 3a019d0
commit 8c5fb01
Showing 4 changed files with 11 additions and 1 deletion.
diff --git a/charts/milvus/Chart.yaml b/charts/milvus/Chart.yaml
@@ -3,7 +3,7 @@ name: milvus
 appVersion: "1.1.1"
 kubeVersion: "^1.10.0-0"
 description: Milvus is an open source similarity search engine for massive-scalefeature vectors.
-version: 1.1.5
+version: 1.1.6
 keywords:
   - milvus
   - elastic

diff --git a/charts/milvus/README.md b/charts/milvus/README.md
@@ -113,6 +113,8 @@ The following table lists the configurable parameters of the Milvus chart and th
 | `logs.path`                               | Absolute path to the folder holding the log files. | `/var/lib/milvus/logs`                             |
 | `logs.maxLogFileSize`                     | The maximum size of each log file, size range [512, 4096]. (MB) | `1024MB`                              |
 | `logs.logRotateNum`                       | The maximum number of log files that Milvus keeps for each logging level, num range [0, 1024], 0 means unlimited. | `0` |
+| `logs.logToStdOut`                        | Whether to output milvus logs on standarad output. | `false` |
+| `logs.logToFile`                          | Whether to output milvus logs on disk. | `true` |
 | `cache.insertBufferSize`                  | Maximum insert buffer size allowed (GB)       | `1GB`                                                   |
 | `cache.cacheSize`                         | Size of CPU memory used for cache  (GB)       | `4GB`                                                   |
 | `network.httpPort`                        | Port that Milvus web server monitors.         | `19121`                                                 |

diff --git a/charts/milvus/templates/_server_config.tpl b/charts/milvus/templates/_server_config.tpl
@@ -182,12 +182,18 @@ gpu:
 # log_rotate_num       | The maximum number of log files that Milvus keeps for each | Integer    | 0               |
 #                      | logging level, num range [0, 1024], 0 means unlimited.     |            |                 |
 #----------------------+------------------------------------------------------------+------------+-----------------+
+# log_to_stdout        | Whether to output milvus logs on standarad output          | Boolean    | false           |
+#----------------------+------------------------------------------------------------+------------+-----------------+
+# log_to_file          | Whether to output milvus logs on disk                      | Boolean    | true            |
+#----------------------+------------------------------------------------------------+------------+-----------------+
 logs:
   level: {{ .Values.logs.level }}
   trace.enable: true
   path: {{ .Values.logs.path }}
   max_log_file_size: {{ .Values.logs.maxLogFileSize }}
   log_rotate_num: {{ .Values.logs.logRotateNum }}
+  log_to_stdout: {{ .Values.logs.logToStdOut }}
+  log_to_file: {{ .Values.logs.logToFile }}
 
 
 #----------------------+------------------------------------------------------------+------------+-----------------+

diff --git a/charts/milvus/values.yaml b/charts/milvus/values.yaml
@@ -13,6 +13,8 @@ logs:
   path: /var/lib/milvus/logs
   maxLogFileSize: 1024MB
   logRotateNum: 0
+  logToStdOut: "false"
+  logToFile: "true"
 
 cache:
   insertBufferSize: 1GB