Add retention time and retention size of rocksmq (#197)

Signed-off-by: quicksilver <[email protected]>
zilliztech · Jul 21, 2021 · 7370d37 · 7370d37
1 parent 82e5c5a
commit 7370d37
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 4 deletions.
diff --git a/charts/milvus/Chart.yaml b/charts/milvus/Chart.yaml
@@ -3,7 +3,7 @@ name: milvus
 appVersion: "2.0.0-rc.2"
 kubeVersion: "^1.10.0-0"
 description: Milvus is an open-source vector database built to power AI applications and vector similarity search.
-version: 2.0.7
+version: 2.0.8
 keywords:
   - milvus
   - elastic

diff --git a/charts/milvus/README.md b/charts/milvus/README.md
@@ -128,6 +128,8 @@ The following table lists the configurable parameters of the Milvus Standalone c
 | `standalone.affinity`                     | Affinity settings for Milvus Standalone pods assignment | `{}`                                          |
 | `standalone.tolerations`                  | Toleration labels for Milvus Standalone pods assignment | `[]`                                          |
 | `standalone.extraEnv`                     | Additional Milvus Standalone container environment variables | `[]`                                     |
+| `standalone.rocksmq.retentionTimeInMinutes` | Set the retention time of rocksmq           | `10080`                                                 |
+| `standalone.rocksmq.retentionSizeInMB`    | Set the retention size of rocksmq             | `0`                                                     |
 | `standalone.persistence.enabled`          | Use persistent volume to store Milvus standalone data | `true`                                          |
 | `standalone.persistence.mountPath` | Milvus standalone data persistence volume mount path | `/var/lib/milvus`                                       |
 | `standalone.persistence.annotations`      | PersistentVolumeClaim annotations             | `{}`                                                    |
@@ -298,7 +300,7 @@ The following table lists the configurable parameters of the Pulsar Standalone c
 | `pulsarStandalone.tolerations`            | Toleration labels for Pulsar Standalone pods assignment | `[]`                                          |
 | `pulsarStandalone.extraEnv`               | Additional Pulsar Standalone container environment variables | `[]`                                     |
 | `pulsarStandalone.service.type`                        | Service type                                  | `ClusterIP`                                |
-| `pulsarStandalone.service.port`                        | Port where service is exposed                 | `19530`                                    |
+| `pulsarStandalone.service.port`                        | Port where service is exposed                 | `6650`                                    |
 | `pulsarStandalone.service.nodePort`                    | Service nodePort                              | `unset`                                    |
 | `pulsarStandalone.service.annotations`                 | Service annotations                           | `{}`                                       |
 | `pulsarStandalone.service.labels`                      | Service custom labels                         | `{}`                                       |
@@ -307,7 +309,7 @@ The following table lists the configurable parameters of the Pulsar Standalone c
 | `pulsarStandalone.service.loadBalancerSourceRanges`    | List of IP CIDRs allowed access to lb (if supported) | `[]`                                |
 | `pulsarStandalone.service.externalIPs`                 | Service external IP addresses                 | `[]`                                       |
 | `pulsarStandalone.persistence.enabled`          | Use persistent volume to store Pulsar standalone data | `true`                                    |
-| `pulsarStandalone.persistence.mountPath` | Pulsar standalone data persistence volume mount path | `/var/lib/milvus`                                 |
+| `pulsarStandalone.persistence.mountPath` | Pulsar standalone data persistence volume mount path | `/pulsar/data`                                 |
 | `pulsarStandalone.persistence.annotations`      | PersistentVolumeClaim annotations             | `{}`                                              |
 | `pulsarStandalone.persistence.persistentVolumeClaim.existingClaim` | Use your own data Persistent Volume existing claim name | `unset`              |
 | `pulsarStandalone.persistence.persistentVolumeClaim.storageClass` | The Pulsar standalone data Persistent Volume Storage Class | `unset`            |

diff --git a/charts/milvus/templates/config.tpl b/charts/milvus/templates/config.tpl
@@ -63,7 +63,9 @@ pulsar:
 {{- end }}
 
 rocksmq:
-  path: "/var/lib/milvus/rdb_data"
+  path: "{{ .Values.standalone.persistence.mountPath }}/rdb_data"
+  retentionTimeInMinutes: {{ .Values.standalone.rocksmq.retentionTimeInMinutes }}
+  retentionSizeInMB: {{ .Values.standalone.rocksmq.retentionSizeInMB }}
 
 rootCoord:
 {{- if .Values.cluster.enabled }}

diff --git a/charts/milvus/values.yaml b/charts/milvus/values.yaml
@@ -81,6 +81,10 @@ standalone:
   tolerations: []
   extraEnv: []
 
+  rocksmq:
+    retentionTimeInMinutes: 10080
+    retentionSizeInMB: 0
+
   persistence:
     mountPath: "/var/lib/milvus"
     ## If true, alertmanager will create/use a Persistent Volume Claim