Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable refine for FAISS HNSW indices by default, if available #932

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

alexanderguzhva
Copy link
Collaborator

@alexanderguzhva alexanderguzhva commented Nov 7, 2024

  • Enable refine for FAISS HNSW indices by default, if available. This fixes the problem in UT, where a non-refined search for refined FAISS HNSW index would not match refined iterator search
  • Remove duplicate test cases in UT
  • Fixes refining for the range search (add range_search() to IndexRefine facebookresearch/faiss#4022)

Copy link

mergify bot commented Nov 7, 2024

@alexanderguzhva 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@alexanderguzhva alexanderguzhva force-pushed the fix_hnsw_pq_iterator branch 5 times, most recently from a81e60e to 3c9993f Compare November 8, 2024 01:05
@sre-ci-robot sre-ci-robot added size/L and removed size/M labels Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.21%. Comparing base (3c46f4c) to head (f832c3f).
Report is 237 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #932       +/-   ##
=========================================
+ Coverage      0   74.21%   +74.21%     
=========================================
  Files         0       82       +82     
  Lines         0     6422     +6422     
=========================================
+ Hits          0     4766     +4766     
- Misses        0     1656     +1656     

see 82 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Nov 8, 2024
.set_range(1, std::numeric_limits<CFG_FLOAT::value_type>::max())
.for_search();
.for_search()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for_iterator?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed .for_range_search(). Technically, range_k is applicable only for the search, neither range_search, not iterator.

Signed-off-by: Alexandr Guzhva <[email protected]>
@foxspy
Copy link
Collaborator

foxspy commented Nov 9, 2024

/kind improvement

@foxspy
Copy link
Collaborator

foxspy commented Nov 9, 2024

/lgtm

@foxspy
Copy link
Collaborator

foxspy commented Nov 9, 2024

/approve

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderguzhva, foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 27dea7f into zilliztech:main Nov 9, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants