-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable refine for FAISS HNSW indices by default, if available #932
enable refine for FAISS HNSW indices by default, if available #932
Conversation
alexanderguzhva
commented
Nov 7, 2024
•
edited
Loading
edited
- Enable refine for FAISS HNSW indices by default, if available. This fixes the problem in UT, where a non-refined search for refined FAISS HNSW index would not match refined iterator search
- Remove duplicate test cases in UT
- Fixes refining for the range search (add range_search() to IndexRefine facebookresearch/faiss#4022)
@alexanderguzhva 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
a81e60e
to
3c9993f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #932 +/- ##
=========================================
+ Coverage 0 74.21% +74.21%
=========================================
Files 0 82 +82
Lines 0 6422 +6422
=========================================
+ Hits 0 4766 +4766
- Misses 0 1656 +1656 |
src/index/hnsw/faiss_hnsw_config.h
Outdated
.set_range(1, std::numeric_limits<CFG_FLOAT::value_type>::max()) | ||
.for_search(); | ||
.for_search() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for_iterator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed .for_range_search()
. Technically, range_k
is applicable only for the search, neither range_search, not iterator.
Signed-off-by: Alexandr Guzhva <[email protected]>
3c9993f
to
f832c3f
Compare
/kind improvement |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexanderguzhva, foxspy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |