Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pyknowhere build fail #1094

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Conversation

cydrain
Copy link
Collaborator

@cydrain cydrain commented Feb 24, 2025

issue: #1093

Copy link

mergify bot commented Feb 24, 2025

@cydrain 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

Signed-off-by: CaiYudong <[email protected]>
@cydrain cydrain force-pushed the caiyd_fix_setuptools branch from 0128dd5 to 65939e0 Compare February 24, 2025 09:28
@cydrain
Copy link
Collaborator Author

cydrain commented Feb 24, 2025

/kind improvement

Copy link
Collaborator

@foxspy foxspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cydrain, foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit d9651b6 into zilliztech:main Feb 24, 2025
6 of 9 checks passed
@cydrain cydrain deleted the caiyd_fix_setuptools branch February 24, 2025 10:30
adarshs1310 pushed a commit to adarshs1310/knowhere that referenced this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants