Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean knowhere build warnings #1082

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

cydrain
Copy link
Collaborator

@cydrain cydrain commented Feb 18, 2025

Issue: #1083

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cydrain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

mergify bot commented Feb 18, 2025

@cydrain 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@cydrain cydrain force-pushed the caiyd_build_warning_as_error branch 3 times, most recently from ef7ad89 to 7973f93 Compare February 18, 2025 06:37
@mergify mergify bot added the ci-passed label Feb 18, 2025
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.04%. Comparing base (3c46f4c) to head (9cc2ad4).
Report is 318 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #1082       +/-   ##
=========================================
+ Coverage      0   72.04%   +72.04%     
=========================================
  Files         0       85       +85     
  Lines         0     8225     +8225     
=========================================
+ Hits          0     5926     +5926     
- Misses        0     2299     +2299     

see 85 files with indirect coverage changes

@cydrain
Copy link
Collaborator Author

cydrain commented Feb 18, 2025

/kind improvement

@cqy123456
Copy link
Collaborator

maybe put these util.h functions in anonymous namespace is better

@cydrain cydrain force-pushed the caiyd_build_warning_as_error branch from 7973f93 to 1318417 Compare February 18, 2025 09:06
@mergify mergify bot removed the ci-passed label Feb 18, 2025
@cydrain cydrain force-pushed the caiyd_build_warning_as_error branch from 1318417 to c4cc795 Compare February 18, 2025 09:38
@cydrain
Copy link
Collaborator Author

cydrain commented Feb 18, 2025

maybe put these util.h functions in anonymous namespace is better

@cqy123456 add namespace, please check again

@mergify mergify bot added the ci-passed label Feb 18, 2025
@@ -16,6 +16,7 @@ if(WITH_ASAN)
endif()

set(CMAKE_CXX_FLAGS "-Wall -fPIC ${CMAKE_CXX_FLAGS}")
#set(CMAKE_CXX_FLAGS "-Wall -Werror -fPIC ${CMAKE_CXX_FLAGS}")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do I get it correct that error reporting was just disabled?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Alex,

I plan to enable "-Werror" to make the compiler treat all warnings as errors.
But because of issue #1081, I cannot enable this flag by now.

@cydrain cydrain force-pushed the caiyd_build_warning_as_error branch from c4cc795 to 9cc2ad4 Compare February 19, 2025 02:51
@mergify mergify bot removed the ci-passed label Feb 19, 2025
@cqy123456
Copy link
Collaborator

/lgtm

@sre-ci-robot sre-ci-robot merged commit 5f3afcd into zilliztech:main Feb 19, 2025
13 of 14 checks passed
@cydrain cydrain deleted the caiyd_build_warning_as_error branch February 19, 2025 03:54
adarshs1310 pushed a commit to adarshs1310/knowhere that referenced this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants