-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean knowhere build warnings #1082
Clean knowhere build warnings #1082
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cydrain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@cydrain 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
ef7ad89
to
7973f93
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1082 +/- ##
=========================================
+ Coverage 0 72.04% +72.04%
=========================================
Files 0 85 +85
Lines 0 8225 +8225
=========================================
+ Hits 0 5926 +5926
- Misses 0 2299 +2299 |
/kind improvement |
maybe put these util.h functions in anonymous namespace is better |
7973f93
to
1318417
Compare
1318417
to
c4cc795
Compare
@cqy123456 add namespace, please check again |
@@ -16,6 +16,7 @@ if(WITH_ASAN) | |||
endif() | |||
|
|||
set(CMAKE_CXX_FLAGS "-Wall -fPIC ${CMAKE_CXX_FLAGS}") | |||
#set(CMAKE_CXX_FLAGS "-Wall -Werror -fPIC ${CMAKE_CXX_FLAGS}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do I get it correct that error reporting was just disabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Alex,
I plan to enable "-Werror" to make the compiler treat all warnings as errors.
But because of issue #1081, I cannot enable this flag by now.
Signed-off-by: CaiYudong <[email protected]>
c4cc795
to
9cc2ad4
Compare
/lgtm |
Signed-off-by: CaiYudong <[email protected]>
Issue: #1083