Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sparse: make bm25 avgdl support value smaller than 1 #1077

Merged
merged 1 commit into from
Feb 15, 2025

Conversation

sparknack
Copy link
Contributor

@sparknack sparknack commented Feb 14, 2025

issue: #1035

Copy link

mergify bot commented Feb 14, 2025

@sparknack 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.08%. Comparing base (3c46f4c) to head (029b204).
Report is 317 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #1077       +/-   ##
=========================================
+ Coverage      0   72.08%   +72.08%     
=========================================
  Files         0       86       +86     
  Lines         0     8206     +8206     
=========================================
+ Hits          0     5915     +5915     
- Misses        0     2291     +2291     

see 86 files with indirect coverage changes

@zhengbuqian
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sparknack, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhengbuqian
Copy link
Collaborator

issue: milvus-io/milvus#39583

/kind fix

@sre-ci-robot
Copy link
Collaborator

@zhengbuqian: The label(s) kind/fix cannot be applied, because the repository doesn't have them.

In response to this:

issue: milvus-io/milvus#39583

/kind fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zhengbuqian
Copy link
Collaborator

/kind bug

@sre-ci-robot sre-ci-robot added the kind/bug This PR is a bug fix label Feb 14, 2025
@zhengbuqian
Copy link
Collaborator

issue: milvus-io/milvus#39583

@sparknack
Copy link
Contributor Author

issue: #1035

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants