Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: scann support search parameter 'ensure_topk_full' #1072

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

cqy123456
Copy link
Collaborator

@cqy123456 cqy123456 commented Feb 12, 2025

issue: #909
related pr:#353

@sre-ci-robot sre-ci-robot requested review from hhy3 and PwzXxm February 12, 2025 07:34
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cqy123456

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

mergify bot commented Feb 12, 2025

@cqy123456 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.07%. Comparing base (3c46f4c) to head (0008c75).
Report is 314 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #1072       +/-   ##
=========================================
+ Coverage      0   72.07%   +72.07%     
=========================================
  Files         0       86       +86     
  Lines         0     8204     +8204     
=========================================
+ Hits          0     5913     +5913     
- Misses        0     2291     +2291     

see 86 files with indirect coverage changes

@alexanderguzhva
Copy link
Collaborator

/lgtm
overall

@foxspy
Copy link
Collaborator

foxspy commented Feb 13, 2025

/kind improvement

@sre-ci-robot sre-ci-robot merged commit 2956cc8 into zilliztech:main Feb 13, 2025
13 of 14 checks passed
adarshs1310 pushed a commit to adarshs1310/knowhere that referenced this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants