Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhence: optimize cmake for milvus lite #1062

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

Presburger
Copy link
Collaborator

@Presburger Presburger commented Feb 10, 2025

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Presburger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

mergify bot commented Feb 10, 2025

@Presburger 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@Presburger Presburger changed the title optimize cmake for milvus lite enhence: optimize cmake for milvus lite Feb 10, 2025
@Presburger
Copy link
Collaborator Author

Presburger commented Feb 10, 2025

/kind enhence

@sre-ci-robot
Copy link
Collaborator

@Presburger: The label(s) kind/enhence cannot be applied, because the repository doesn't have them.

In response to this:

/kind enhence

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

mergify bot commented Feb 10, 2025

@Presburger 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@Presburger
Copy link
Collaborator Author

#1063

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.05%. Comparing base (3c46f4c) to head (7bf4dc8).
Report is 310 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #1062       +/-   ##
=========================================
+ Coverage      0   72.05%   +72.05%     
=========================================
  Files         0       86       +86     
  Lines         0     8196     +8196     
=========================================
+ Hits          0     5906     +5906     
- Misses        0     2290     +2290     

see 86 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Feb 10, 2025
@alexanderguzhva
Copy link
Collaborator

/lgtm

@sre-ci-robot sre-ci-robot merged commit fe7a61e into zilliztech:main Feb 11, 2025
13 of 14 checks passed
Presburger added a commit that referenced this pull request Feb 11, 2025
adarshs1310 pushed a commit to adarshs1310/knowhere that referenced this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants