Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label filter for pinecone #460

Conversation

alwayslove2013
Copy link
Collaborator

/hold

wait pr: #455

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alwayslove2013
To complete the pull request process, please assign xuanyang-cn after the PR has been reviewed.
You can assign the PR to them by writing /assign @xuanyang-cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alwayslove2013 alwayslove2013 force-pushed the label_filter_for_pinecone branch from b2799cf to b5c24bb Compare January 24, 2025 03:38
Signed-off-by: wxywb <xy.wang@zilliz.com>
@alwayslove2013 alwayslove2013 force-pushed the label_filter_for_pinecone branch from b5c24bb to 7b07eb9 Compare February 13, 2025 03:32
Signed-off-by: min.tian <min.tian.cn@gmail.com>
@alwayslove2013 alwayslove2013 force-pushed the label_filter_for_pinecone branch from 7b07eb9 to 4cf912c Compare February 13, 2025 03:35
@alwayslove2013
Copy link
Collaborator Author

/unhold

@alwayslove2013 alwayslove2013 merged commit 93db5a9 into zilliztech:vdbbench_1.0 Feb 13, 2025
4 checks passed
@alwayslove2013 alwayslove2013 deleted the label_filter_for_pinecone branch February 13, 2025 03:40
alwayslove2013 added a commit to alwayslove2013/VectorDBBench that referenced this pull request Feb 17, 2025
* feat: add label filtering to pinecone client.

Signed-off-by: wxywb <xy.wang@zilliz.com>

* fix: pinecone filters

Signed-off-by: min.tian <min.tian.cn@gmail.com>

---------

Signed-off-by: wxywb <xy.wang@zilliz.com>
Signed-off-by: min.tian <min.tian.cn@gmail.com>
Co-authored-by: wxywb <xy.wang@zilliz.com>
alwayslove2013 added a commit that referenced this pull request Feb 17, 2025
* feat: add label filtering to pinecone client.

Signed-off-by: wxywb <xy.wang@zilliz.com>

* fix: pinecone filters

Signed-off-by: min.tian <min.tian.cn@gmail.com>

---------

Signed-off-by: wxywb <xy.wang@zilliz.com>
Signed-off-by: min.tian <min.tian.cn@gmail.com>
Co-authored-by: wxywb <xy.wang@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants